-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v3): Port jobs context menu changes from 2689 #2743
Conversation
Signed-off-by: adam-wolfe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @adam-wolfe!
Signed-off-by: Adam Wolfe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2743 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 109 109
Lines 10228 10228
Branches 2173 2075 -98
=======================================
Hits 9555 9555
Misses 672 672
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Quality Gate passedIssues Measures |
Proposed changes
Resolves #2670 for v3.
Release Notes
Milestone:
Changelog:
Adjusted order of 'Manage Profile' and 'Edit History' in the jobs tree's context menu to match the other trees.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments